Skip to content

small tweak on addRouteRecord function #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2017
Merged

small tweak on addRouteRecord function #1285

merged 3 commits into from
Jun 16, 2017

Conversation

javoski
Copy link
Member

@javoski javoski commented Mar 28, 2017

No description provided.

@LinusBorg
Copy link
Member

LGTM

@posva
Copy link
Member

posva commented May 28, 2017

ping @yyx990803 is it better to not modify any of routes properties and create a new property instead?

const routeAliases = isArray ? route.alias : [route.alias]

@yyx990803 yyx990803 merged commit 0aea9c5 into vuejs:dev Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@posva posva posva approved these changes

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javoski @LinusBorg @posva @kazupon @yyx990803